Persist enhancements #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now use localForage that wraps IndexedDB and also uses localStorage as a fallback storage option. It has has the exact same API as localStorage.
The main difference is that it is async. As a result, the hard part of this PR was to orchestrate the loading process to accommodate that. Fortunately, that also fixed some loading related issues, because we now have a single event that initializes our db.
akiroz.re-frame/storagedependency was removed. We now use custom effects to write a serialized state of the app on a single db key. This is by no means a sophisticated storage approach, but it seems to work fine. If we decide to more than that, we might as well write to IndexedDB directly, or use something like re-posh and skip re-frame's app-db altogether.Resolves #75